feat(kraft): Introduce global CPU profiling env var #1865
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nderjung
force-pushed
the
nderjung/feat/pprof
branch
from
2d3f153
to
bc4e2e2
Compare
This commit introduces the ability to enables Go's internal pprof module which samples the CPU. This allows developers to measure the performance of `kraft` itself and its associated call tree, allowing for performance debugging and optimization. Simply set the environmental variable `KRAFTKIT_CPU_PROFILE` on any `kraft` invocation to the path to save the profile data, e.g.: ``` KRAFTKIT_CPU_PROFILE=./out.txt kraft [...] ``` Once the command has been completed, one can access the data using Go's internal tooling, e.g. via a web UI: ``` go tool pprof -http 0.0.0.0:8181 ./out.txt ``` Signed-off-by: Alexander Jung <alex@unikraft.io>
nderjung
force-pushed
the
nderjung/feat/pprof
branch
from
bc4e2e2
to
709eed8
Compare
craciunoiuc
approved these changes
Aug 26, 2024
There was a problem hiding this comment.
All good here. Thanks!
Reviewed-by: Cezar Craciunoiu cezar.craciunoiu@unikraft.io
Approved-by: Cezar Craciunoiu cezar.craciunoiu@unikraft.io
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit introduces the ability to enables Go's internal pprof module which samples the CPU. This allows developers to measure the performance of
kraftitself and its associated call tree, allowing for performance debugging and optimization.Simply set the environmental variable
KRAFTKIT_CPU_PROFILEn anykraftinvocation to the path to save the profile data, e.g.:Once the command has been completed, one can access the data using Go's internal tooling, e.g. via a web UI:
Prerequisite checklist
make fmton your commit series before opening this PR;Description of changes